clean: remove opencl #366
Merged
clean: remove opencl #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughThe changes in this pull request primarily focus on updating workflow configurations for building and testing applications with Vulkan support while removing references to the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant CI as CI/CD Pipeline
participant Repo as Repository
participant Vulkan as Vulkan SDK
participant Tauri as Tauri Build
User->>CI: Trigger Build
CI->>Repo: Checkout Code
CI->>Vulkan: Prepare Vulkan SDK
CI->>Tauri: Build Application
Tauri->>CI: Return Build Artifacts
CI->>User: Notify Build Completion
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
.vscode/launch.json (1)
63-64: LGTM! The removal of CLBlast configurations aligns with the PR objectives.The changes correctly remove CLBlast-related paths while maintaining the necessary OpenBLAS and FFmpeg configurations.
Consider adding platform-specific launch configurations for better cross-platform support. Here's a suggested approach:
{ "configurations": [ { "name": "Debug executable 'vibe' in Release mode (Windows)", "windows": { "env": { "PATH": "${env:PATH};${workspaceFolder}\\desktop\\src-tauri\\openblas\\bin;${workspaceFolder}\\desktop\\src-tauri\\ffmpeg\\bin\\x64", "RUSTFLAGS": "-L ${workspaceFolder}\\desktop\\src-tauri\\openblas\\lib" } } }, { "name": "Debug executable 'vibe' in Release mode (Linux/macOS)", "linux": { "env": { "PATH": "${env:PATH}:${workspaceFolder}/desktop/src-tauri/openblas/bin:${workspaceFolder}/desktop/src-tauri/ffmpeg/bin/x64", "RUSTFLAGS": "-L ${workspaceFolder}/desktop/src-tauri/openblas/lib" } }, "osx": { "env": { "PATH": "${env:PATH}:${workspaceFolder}/desktop/src-tauri/openblas/bin:${workspaceFolder}/desktop/src-tauri/ffmpeg/bin/x64", "RUSTFLAGS": "-L ${workspaceFolder}/desktop/src-tauri/openblas/lib" } } } ] }docs/BUILDING.md (1)
35-41: Improve documentation formatting and clarity for Vulkan setup on Windows.
- Use proper heading format instead of emphasis
- Add explanation for why admin privileges are required
- Use forward slashes in the command for better cross-platform compatibility
Apply these changes:
-_Vulkan (Windows)_ +### Vulkan (Windows) -**Run as admin once!!!** +> **Important**: Administrative privileges are required for the first run to set up Vulkan SDK components properly. ```console -bun run scripts\pre_build.js --vulkan +bun run scripts/pre_build.js --vulkan<details> <summary>🧰 Tools</summary> <details> <summary>🪛 Markdownlint</summary> 35-35: null Emphasis used instead of a heading (MD036, no-emphasis-as-heading) </details> </details> </blockquote></details> </blockquote></details> <details> <summary>📜 Review details</summary> **Configuration used: CodeRabbit UI** **Review profile: CHILL** <details> <summary>📥 Commits</summary> Reviewing files that changed from the base of the PR and between 9edf658983446c7bd09c575c3b8c658f95fde777 and bfc9b9632727c185f156744764dc9aabb7d2912b. </details> <details> <summary>📒 Files selected for processing (8)</summary> * `.github/workflows/linux_special.yml` (0 hunks) * `.github/workflows/test_core.yml` (0 hunks) * `.gitignore` (0 hunks) * `.vscode/launch.json` (1 hunks) * `core/build.rs` (0 hunks) * `desktop/src-tauri/tauri.windows.conf.json` (1 hunks) * `docs/BUILDING.md` (1 hunks) * `scripts/pre_build.js` (0 hunks) </details> <details> <summary>💤 Files with no reviewable changes (5)</summary> * .github/workflows/linux_special.yml * .github/workflows/test_core.yml * .gitignore * core/build.rs * scripts/pre_build.js </details> <details> <summary>🧰 Additional context used</summary> <details> <summary>🪛 Markdownlint</summary> <details> <summary>docs/BUILDING.md</summary> 35-35: null Emphasis used instead of a heading (MD036, no-emphasis-as-heading) </details> </details> </details> <details> <summary>🔇 Additional comments (3)</summary> <details> <summary>desktop/src-tauri/tauri.windows.conf.json (2)</summary> `9-10`: **LGTM! Configuration changes align with Vulkan transition.** The addition of Vulkan runtime DLLs to the resources bundle is consistent with the PR's objective of removing OpenCL and transitioning to Vulkan support. --- `10-10`: **Verify Vulkan runtime path and required DLLs.** Please ensure that the path `vulkan_runtime\x64\` exists in your project structure and contains all necessary Vulkan runtime DLLs for Windows builds. </details> <details> <summary>docs/BUILDING.md (1)</summary> Line range hint `1-999`: **LGTM! Changes align with PR objectives.** The removal of OpenCL/clblast related content is complete and consistent throughout the documentation. The addition of Vulkan-specific instructions maintains the document's completeness for different build configurations. <details> <summary>🧰 Tools</summary> <details> <summary>🪛 Markdownlint</summary> 35-35: null Emphasis used instead of a heading (MD036, no-emphasis-as-heading) </details> </details> </details> </details> </details> <!-- This is an auto-generated comment by CodeRabbit for review status -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Release Notes
New Features
Bug Fixes
clblastacross various configurations and scripts, streamlining the build process.Documentation
BUILDING.mdto reflect changes in build requirements and instructions regarding Vulkan andclblast.Chores
.gitignoreto exclude additional file types and directories, improving repository cleanliness.